-
Notifications
You must be signed in to change notification settings - Fork 306
Add external communication opt-out for browser runtime #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
genkio
wants to merge
4
commits into
aidenybai:main
Choose a base branch
from
genkio:disable-external-communication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| import { test, expect } from "@playwright/test"; | ||
|
|
||
| test.describe("External Communication", () => { | ||
| test("should skip external requests during initialization when disabled", async ({ | ||
| page, | ||
| }) => { | ||
| const requestedUrls: string[] = []; | ||
|
|
||
| page.on("request", (request) => { | ||
| const requestUrl = request.url(); | ||
| if ( | ||
| requestUrl.startsWith("https://www.react-grab.com/api/version") || | ||
| requestUrl.startsWith("https://fonts.googleapis.com/") | ||
| ) { | ||
| requestedUrls.push(requestUrl); | ||
| } | ||
| }); | ||
|
|
||
| await page.addInitScript(() => { | ||
| ( | ||
| window as { | ||
| __REACT_GRAB_OPTIONS__?: { | ||
| allowExternalCommunication?: boolean; | ||
| }; | ||
| } | ||
| ).__REACT_GRAB_OPTIONS__ = { | ||
| allowExternalCommunication: false, | ||
| }; | ||
| }); | ||
|
|
||
| await page.goto("/", { waitUntil: "domcontentloaded" }); | ||
| await page.waitForFunction( | ||
| () => (window as { __REACT_GRAB__?: unknown }).__REACT_GRAB__ !== undefined, | ||
| { timeout: 5000 }, | ||
| ); | ||
| await page.waitForTimeout(300); | ||
|
|
||
| expect(requestedUrls).toEqual([]); | ||
|
|
||
| const hasFontLink = await page.evaluate(() => { | ||
| return document.getElementById("react-grab-fonts") !== null; | ||
| }); | ||
|
|
||
| expect(hasFontLink).toBe(false); | ||
| }); | ||
|
|
||
| test("should not open a remote open-file fallback from the selection label when disabled", async ({ | ||
| page, | ||
| }) => { | ||
| await page.addInitScript(() => { | ||
| ( | ||
| window as { | ||
| __REACT_GRAB_OPTIONS__?: { | ||
| allowExternalCommunication?: boolean; | ||
| }; | ||
| } | ||
| ).__REACT_GRAB_OPTIONS__ = { | ||
| allowExternalCommunication: false, | ||
| }; | ||
| }); | ||
|
|
||
| await page.goto("/", { waitUntil: "domcontentloaded" }); | ||
| await page.waitForFunction( | ||
| () => (window as { __REACT_GRAB__?: unknown }).__REACT_GRAB__ !== undefined, | ||
| { timeout: 5000 }, | ||
| ); | ||
|
|
||
| await page.evaluate(() => { | ||
| (window as { __OPEN_FILE_URLS__?: string[] }).__OPEN_FILE_URLS__ = []; | ||
|
|
||
| const originalFetch = window.fetch.bind(window); | ||
| window.fetch = async (input, init) => { | ||
| const requestUrl = | ||
| typeof input === "string" | ||
| ? input | ||
| : input instanceof URL | ||
| ? input.toString() | ||
| : input.url; | ||
| if ( | ||
| requestUrl.includes("/__open-in-editor") || | ||
| requestUrl.includes("/__nextjs_launch-editor") | ||
| ) { | ||
| return new Response("", { status: 404 }); | ||
| } | ||
| return originalFetch(input, init); | ||
| }; | ||
|
|
||
| Object.defineProperty(window, "open", { | ||
| configurable: true, | ||
| value: (url?: string | URL) => { | ||
| const openUrls = | ||
| (window as { __OPEN_FILE_URLS__?: string[] }).__OPEN_FILE_URLS__ ?? | ||
| []; | ||
| openUrls.push(typeof url === "string" ? url : String(url ?? "")); | ||
| (window as { __OPEN_FILE_URLS__?: string[] }).__OPEN_FILE_URLS__ = | ||
| openUrls; | ||
| return null; | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| await page.evaluate(() => { | ||
| const api = ( | ||
| window as { | ||
| __REACT_GRAB__?: { | ||
| activate: () => void; | ||
| }; | ||
| } | ||
| ).__REACT_GRAB__; | ||
| api?.activate(); | ||
| }); | ||
| await page.waitForFunction( | ||
| () => | ||
| ( | ||
| window as { | ||
| __REACT_GRAB__?: { | ||
| isActive: () => boolean; | ||
| }; | ||
| } | ||
| ).__REACT_GRAB__?.isActive() === true, | ||
| { timeout: 5000 }, | ||
| ); | ||
|
|
||
| const firstListItem = page.locator("li").first(); | ||
| await firstListItem.hover({ force: true }); | ||
|
|
||
| await page.waitForFunction( | ||
| () => { | ||
| const api = ( | ||
| window as { | ||
| __REACT_GRAB__?: { | ||
| getState: () => { | ||
| isSelectionBoxVisible: boolean; | ||
| targetElement: unknown; | ||
| selectionFilePath: string | null; | ||
| }; | ||
| }; | ||
| } | ||
| ).__REACT_GRAB__; | ||
| const state = api?.getState(); | ||
| return Boolean( | ||
| (state?.isSelectionBoxVisible || state?.targetElement) && | ||
| state?.selectionFilePath, | ||
| ); | ||
| }, | ||
| { timeout: 5000 }, | ||
| ); | ||
|
|
||
| const selectionLabelOpenButton = page.locator( | ||
| "[data-react-grab-selection-label] .cursor-pointer", | ||
| ); | ||
| await expect(selectionLabelOpenButton).toBeVisible(); | ||
| await selectionLabelOpenButton.click({ force: true }); | ||
| await page.waitForTimeout(200); | ||
|
|
||
| const openUrls = await page.evaluate(() => { | ||
| return (window as { __OPEN_FILE_URLS__?: string[] }).__OPEN_FILE_URLS__; | ||
| }); | ||
|
|
||
| expect(openUrls ?? []).toEqual([]); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.