Open
Conversation
Contributor
|
Error agent completed without reporting progress |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@react-grab/cli
grab
@react-grab/amp
@react-grab/claude-code
@react-grab/codex
@react-grab/copilot
@react-grab/cursor
@react-grab/droid
@react-grab/gemini
@react-grab/opencode
react-grab
@react-grab/relay
@react-grab/utils
commit: |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+1624
to
+1627
| if (!isPendingDismiss()) { | ||
| actions.setPendingDismiss(true); | ||
| return; | ||
| } | ||
|
|
||
| actions.clearInputText(); | ||
| actions.clearReplySessionId(); | ||
| deactivateRenderer(); | ||
| setSelectionLabelShakeCount((count) => count + 1); |
Contributor
There was a problem hiding this comment.
Escape key behavior broken - always triggers shake animation even when dismiss is already pending, breaks the expected two-press escape flow
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 18 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/react-grab/src/core/index.tsx">
<violation number="1" location="packages/react-grab/src/core/index.tsx:1624">
P1: `handleInputCancel` no longer has any path that calls `deactivateRenderer`. Two regressions:
1. **Empty input shows unnecessary discard prompt** — the old `currentInput` check is gone, so canceling with an empty input now shows a "Discard?" prompt instead of immediately deactivating.
2. **Mouse/touch users are trapped** — when `isPendingDismiss` is already `true`, subsequent cancel triggers (e.g., clicking outside the selection) just increment the shake count and never deactivate. Keyboard users can still escape via the `DiscardPrompt` buttons, but mouse-only users have no way out.
Restore the empty-input fast-path and the second-cancel deactivation path.</violation>
</file>
<file name="packages/react-grab/src/components/selection-label/index.tsx">
<violation number="1" location="packages/react-grab/src/components/selection-label/index.tsx:445">
P2: Add `onAnimationCancel` to ensure the `isShaking` state resets if the animation is aborted.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| style={{ | ||
| display: isCompletedStatus() && !props.error ? "none" : undefined, | ||
| }} | ||
| onAnimationEnd={() => setIsShaking(false)} |
Contributor
There was a problem hiding this comment.
P2: Add onAnimationCancel to ensure the isShaking state resets if the animation is aborted.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/react-grab/src/components/selection-label/index.tsx, line 445:
<comment>Add `onAnimationCancel` to ensure the `isShaking` state resets if the animation is aborted.</comment>
<file context>
@@ -418,10 +437,12 @@ export const SelectionLabel: Component<SelectionLabelProps> = (props) => {
style={{
display: isCompletedStatus() && !props.error ? "none" : undefined,
}}
+ onAnimationEnd={() => setIsShaking(false)}
>
<Show when={props.status === "copying" && !props.isPendingAbort}>
</file context>
Suggested change
| onAnimationEnd={() => setIsShaking(false)} | |
| onAnimationEnd={() => setIsShaking(false)} | |
| onAnimationCancel={() => setIsShaking(false)} |
| style={{ | ||
| display: isCompletedStatus() && !props.error ? "none" : undefined, | ||
| }} | ||
| onAnimationEnd={() => setIsShaking(false)} |
Contributor
There was a problem hiding this comment.
Missing onAnimationCancel handler leaves isShaking=true when animation is cancelled by display property change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk due to breaking public API/theme changes (removal of crosshair-related options/state/hook) and UI behavior changes around prompt cancel/dismiss flows that could affect user interactions.
Overview
Removes the crosshair overlay feature end-to-end: drops
theme.crosshair,onCrosshairhook, andisCrosshairVisible/crosshairVisiblestate/props; deletes crosshair rendering and pointermove tracking fromOverlayCanvas, and updates e2e coverage accordingly.Improves selection label UX: adds
selectionLabelShakeCountto trigger a shake animation on cancel-to-dismiss, refocuses the input when dismiss is canceled, and updates label positioning logic to account forvisualViewportoffsets/scroll/resize for better behavior with zoom/virtual keyboards.Tweaks toolbar history indicator: replaces the unread dot with a numeric badge that shows
historyItemCount(only when unread and count > 0).Written by Cursor Bugbot for commit 0c67391. This will update automatically on new commits. Configure here.
Summary by cubic
Removes the crosshair overlay and related theme/hook/state APIs to simplify the UI, improves selection label positioning and cancel behavior, and replaces the toolbar history unread dot with a numeric badge.
New Features
visualViewportoffsets and scroll/resize listeners.hasUnreadHistoryItemsandhistoryItemCount > 0.Migration
theme.crosshair(no replacement).onCrosshairhook andCrosshairContexttypes.isCrosshairVisiblefromReactGrabStateandcrosshairVisibleprop from the renderer/overlay.Written for commit 0c67391. Summary will update on new commits.