Skip to content

Silencing Pandas downcasting warning on df creation #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Silencing Pandas downcasting warning on df creation #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions gspread_pandas/spread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,12 +396,13 @@ def sheet_to_df(
col_names = parse_sheet_headers(vals, header_rows)

# remove rows where everything is null, then replace nulls with ''
df = (
pd.DataFrame(vals[header_rows or 0 :])
.replace("", np.nan)
.dropna(how="all")
.fillna("")
)
with pd.option_context('future.no_silent_downcasting', True):
df = (
pd.DataFrame(vals[header_rows or 0 :])
.replace("", np.nan)
.dropna(how="all")
.fillna("")
)

# replace values with a different value render option before we set the
# index in set_col_names
Expand Down