Skip to content

Add tox support to cram workspace#37

Closed
Nicoretti wants to merge 15 commits intoaiiie:masterfrom
prysk:master
Closed

Add tox support to cram workspace#37
Nicoretti wants to merge 15 commits intoaiiie:masterfrom
prysk:master

Conversation

@Nicoretti
Copy link

@Nicoretti Nicoretti commented Dec 26, 2021

Hi Brodie,

I hope you are doing well.

I am a huge fan of cram and recently I was digging more into it. I feel there is still some more potential
in cram (Don't get me wrong, the current state is already great!).

First thing I usually do when I pickup a project, is try to getting it to build and get the tests running.
While doing this for cram I figured, the testing/verification could be simplified by using tox.
For example the test matrix python-version(s) + shell(s).

I think there would be even more potential in using tox, but it most likely would
break compatibility with the Makefile workflow.

When I created the PR I also realised there are a similar PRs #22 #23 which may be closed in case this one will make it in.

I also have dropped support/builds in travis CI for all unsupported python versions.

Let me know what you think about it.

Best
Nico

This commit introduces a tox.ini file which mimiks the behaviour of the
Makefile which is used for verifying and testing the cram project.

Attention:
The build and install step is not explicitly added, because tox already
takes care about this by default.
See also: https://tox.wiki/en/latest/index.html

For now tox just will simplify the local and the CI multi environment test execution.
In case the Makefile path will be removed in the future, the tox.ini
could be improved to more cleanly seperate different concerns like:
linting, coverage, integratin testing, unit testing etc.
@Nicoretti Nicoretti changed the title Adding tox support to cram workspace Add tox support to cram workspace Dec 26, 2021
@aiiie
Copy link
Owner

aiiie commented Dec 27, 2021

Is it still possible to use Travis for free? My interaction with their support team leads me to think not.

Is there another service that could be used for builds?

@aiiie
Copy link
Owner

aiiie commented Dec 27, 2021

@Nicoretti
Copy link
Author

Hi @Brodie,

I just checked, seems you are right. It looks like that you have some free tokens for oss repos, but generally the
payment structure is not very transparent. I think GitHub Actions would be a legit alternative.

@Nicoretti
Copy link
Author

If you are interested in having it run with GitHub Action(s) I can look into it tomorrow

@Nicoretti
Copy link
Author

@Brodie migrated a basic version of the test setup to GitHub, with a couple of small adjustments in the setup (see commits above) it seems to work just fine (https://github.com/Nicoretti/cram/actions/runs/1629899894)

by providing a python based implementation of the md5
hasing tool, it will incrase the platform independence
of cram tets using it.
@kynan
Copy link

kynan commented Jan 16, 2022

I suggest switching to GitHub actions, which allows running tests across Linux, MacOS and Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants