fix: reduce grid rerenders in home sections#377
fix: reduce grid rerenders in home sections#377jonsch318 wants to merge 1 commit intoaimok04:mainfrom
Conversation
|
Hi @jonsch318 Thanks for the PRs, I'll take a deeper look at them at the weekend but they already seem pretty solid. Thanks for the work (and thanks for digging through the tbf a bit messy code 😅) |
|
@aimok04 no problem, honestly take good your time. I will not stop working on it and there are few things I want to do very soon. Most of the PRs and my upcoming ones are proposals, since I did not clear them with you and for me it's simpler to just program it and show you what changes i think are good. Of course it's your project in the end. I will just keep working on it and making PR's to get it into my dream state. Very nice app in general it's in good enough state where it really pays off for me to improve it to my taste :D |
|
But I will try to keep the PRs smaller and well contained and just do more |
This reduces the rerenders of the dynamic home grid and thus reduces the frequent flashing I see maybe even speed things up.
section.titleis enough for a stable identifier.pageLoadingState = ErrorLoadingSuccessState.SUCCESSmultiple times potentially causing rerenders