Skip to content

fix: reduce grid rerenders in home sections#377

Open
jonsch318 wants to merge 1 commit intoaimok04:mainfrom
jonsch318:home-rerender-fix
Open

fix: reduce grid rerenders in home sections#377
jonsch318 wants to merge 1 commit intoaimok04:mainfrom
jonsch318:home-rerender-fix

Conversation

@jonsch318
Copy link
Copy Markdown

This reduces the rerenders of the dynamic home grid and thus reduces the frequent flashing I see maybe even speed things up.

  • For this the grid state was remembering with the section hash, which unfortunately changes to often. From my experimentation section.title is enough for a stable identifier.
  • in items key the recipe index is enough we don't need more
  • I don't know if toList is a good idea on Effect keys since it creates a new list. And we were setting pageLoadingState = ErrorLoadingSuccessState.SUCCESS multiple times potentially causing rerenders

@aimok04
Copy link
Copy Markdown
Owner

aimok04 commented Apr 14, 2026

Hi @jonsch318

Thanks for the PRs, I'll take a deeper look at them at the weekend but they already seem pretty solid.

Thanks for the work (and thanks for digging through the tbf a bit messy code 😅)

@jonsch318
Copy link
Copy Markdown
Author

@aimok04 no problem, honestly take good your time. I will not stop working on it and there are few things I want to do very soon. Most of the PRs and my upcoming ones are proposals, since I did not clear them with you and for me it's simpler to just program it and show you what changes i think are good. Of course it's your project in the end.
Currently I am working on rendering, scroll and request optimizations particularly the homescreen. And want to experiment with intensive caching & room db caching...

I will just keep working on it and making PR's to get it into my dream state. Very nice app in general it's in good enough state where it really pays off for me to improve it to my taste :D

@jonsch318
Copy link
Copy Markdown
Author

But I will try to keep the PRs smaller and well contained and just do more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants