fix(auth): Support Brave, Arc, and Opera browser cookie extraction#101
Merged
fix(auth): Support Brave, Arc, and Opera browser cookie extraction#101
Conversation
Pass explicit cookie database paths when source is Brave, Arc, or Opera, so sweet-cookie only accesses that browser's keychain entry. This ensures a single password prompt instead of multiple prompts for different Chromium browsers. This is a workaround until steipete/sweet-cookie#1 adds the chromiumBrowser option. See #100 for tracking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ainergiz
force-pushed
the
fix/brave-arc-cookies
branch
from
104fd14 to
f2f7384
Compare
ainergiz
changed the title
The npm version of sweet-cookie doesn't have the chromiumBrowser option yet (awaiting upstream PR steipete/sweet-cookie#2). Without it, selecting Brave/Arc prompts for Chrome's keychain instead of the correct one. This vendored version includes the chromiumBrowser option, which tells sweet-cookie which specific Chromium browser's keychain to use for cookie decryption. Once the upstream PR is merged and published, we can switch back to npm. Fixes #100 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Brave, Arc, and Opera browser authentication by passing explicit cookie database paths to sweet-cookie.
Without this fix, selecting these browsers in the picker would try to read Chrome's cookies instead, causing auth to fail.
Changes
getChromiumCookiePath()to resolve explicit cookie DB paths for Brave/Arc/OperachromeProfileso sweet-cookie accesses the correct keychainWhy This Workaround
The upstream
@steipete/sweet-cookiedoesn't yet have thechromiumBrowseroption that would handle this cleanly. We've submitted a PR for it: steipete/sweet-cookie#2Fixes #100
🤖 Generated with Claude Code