[proposal] linking the view pool to activities to lifecycle owner#1099
Draft
eboudrant wants to merge 1 commit intoairbnb:masterfrom
Draft
[proposal] linking the view pool to activities to lifecycle owner#1099eboudrant wants to merge 1 commit intoairbnb:masterfrom
eboudrant wants to merge 1 commit intoairbnb:masterfrom
Conversation
…ink to a lifecycle owner? The problem is with Hilt, there is a memory leak. The memory leak is because Epoxy link the view pool to the activity however, when a view get inflated in a Hilt fragment, the context is a wrapper and hold a reference on the fragment. The fragment leak. So why Epoxy link the view pool arbitrary to the `Activity`. Instead, could we use the view's context and find the closest `LifecycleOwner`. Use the `LifecycleOwner`'s lifecycle ti decide when to clear the pool. However this change won't be enough to fix the memory leak we have with Hilt. We will also need this change in Hilt :
elihart
reviewed
Dec 2, 2020
Contributor
elihart
left a comment
elihart
left a comment
There was a problem hiding this comment.
I think this makes a lot of sense, and is cleaner anyway. I can't think of any cases it wouldn't work in, although I also don't know when the context wouldn't be an Activity (possible a Compose context? but epoxy wouldn't really be used there anyway, unless we have some interop)
| } | ||
|
|
||
| if (isFinishing) { | ||
| if (lifecycle.currentState >= Lifecycle.State.DESTROYED) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal and will require an update to Hilt, see google/dagger#2202 (comment).
The idea of theses changes in to Epoxy and Hilt are to fix a memory leak. It happen because Epoxy link the view pool to the activity. However, when a view get inflated in a Hilt fragment, the view's context is a wrapper and hold a reference on the fragment. The fragment leak for the whole activity lifecycle.
So why Epoxy link the view pool arbitrary to the
Activity? Instead, could we use the view's context and find the closestLifecycleOwner. When this lifecycle get destroyed we can clear the pool.It is a proposal, happy to discuss here. Using the
LifecycleOwnerinstead ofActivitylooks natural. Is it possible to use Epoxy outside of anActivitythat is not aLifecycleOwner?