Skip to content

[iOS] Add ability to use Non ReactNative controllers as Tab #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[iOS] Add ability to use Non ReactNative controllers as Tab #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/ios/native-navigation/TabViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,18 @@ final class TabView: UIView {
return viewController
}

// TODO(lmr): handle non-RN tabs
let coordinator = ReactNavigationCoordinator.sharedInstance

if let route = route {
let vc = ReactViewController(moduleName: route, props: props).prepareViewControllerForPresenting()
vc.tabBarItem = tabBarItem
viewController = vc
guard let flow = coordinator.delegate?.flowCoordinatorForId?(route) as? UIViewController else {
let vc = ReactViewController(moduleName: route, props: props).prepareViewControllerForPresenting()
vc.tabBarItem = tabBarItem
return vc
}
(flow as! ReactFlowCoordinator).start(props)
Copy link
Author

@hpstuff hpstuff Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add other method for ReactFlowCoordinator in order to pass props but this is up for discussions.

flow.tabBarItem = tabBarItem

viewController = coordinator.navigation.makeNavigationController(rootViewController: flow)
}

return viewController
Expand Down