Raise an error when someone attempts to aim at a percent based strategy #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegy This change disables new uses of the percent and percent_visited strategies and also introduces the new aliases percent_drecated and percent_visited_deprecated. The goal is to switch all current uses of the percent based strategies over to the *deprecated alias names after this change goes out. This will enable us to follow up with another commit that corrects the implementation of the percent based strategies without affecting the set of users that are exposed to the deprecated implementation of the strategies. We hope to re-implement the percent based strategies in a way that can be used safely with experiment analysis. The current implemention tends to distribute features using the percent based strategies over the same subsets of users making it difficult to draw conclusions from the results of the analysis of those features. Testing: I wrote new specs and verified that all specs passed
There was a problem hiding this comment.
Might be clearer to break this out into two tests that each have one assertion (even if they both just call should_only_launch_to_a_percentage_of_users).
Contributor
Author
There was a problem hiding this comment.
I thought about that, but seems overkill for a temporary commit that is just being used until I ship the next version that fixes the percent implementation.
|
LGTM, especially if this stuff is just temporary. |
lib/trebuchet/feature.rb
Outdated
There was a problem hiding this comment.
Is this also temporary? Our ruby style guide sez
"Avoid the usage of class (@@) variables due to their "nasty" behavior in inheritance."
|
LGTM Delightful to see trebuchet get love! |
Contributor
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables new uses of the percent and percent_visited strategies and also introduces the new aliases percent_deprecated and percent_visited_deprecated.
The goal is to switch all current uses of the percent based strategies over to the *deprecated alias names after this change goes out. This will enable us to follow up with another commit that corrects the implementation of the percent based strategies without affecting the set of users that are exposed to the deprecated implementation of the strategies.
We hope to re-implement the percent based strategies in a way that can be used safely with experiment analysis. The current implemention tends to distribute features using the percent based strategies over the same subsets of users making it difficult to draw conclusions from the results of the analysis of those features.
Note that my editor strips trailing whitespace. Not sure what people think about that yet ;).
@mcharkov it would be great to get you to review this.
Testing:
I wrote new specs and verified that all specs passed