Skip to content

Add possibility to update group member #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aivanovski merged 3 commits into from
Aug 19, 2025
Merged

Add possibility to update group member #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1c6123
[BACKEND] Add request to update group member
aivanovski Aug 17, 2025
31a922d
Update Kotlin API classes
aivanovski Aug 17, 2025
0ee5080
[ANDROID] Add member update
aivanovski Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions android/app/src/main/java/com/github/ai/simplesplit/android/data/api/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import com.github.ai.split.api.request.PostGroupRequest
import com.github.ai.split.api.request.PostMemberRequest
import com.github.ai.split.api.request.PutExpenseRequest
import com.github.ai.split.api.request.PutGroupRequest
import com.github.ai.split.api.request.PutMemberRequest
import com.github.ai.split.api.response.DeleteExpenseResponse
import com.github.ai.split.api.response.DeleteMemberResponse
import com.github.ai.split.api.response.GetGroupsResponse
Expand All @@ -19,6 +20,7 @@ import com.github.ai.split.api.response.PostGroupResponse
import com.github.ai.split.api.response.PostMemberResponse
import com.github.ai.split.api.response.PutExpenseResponse
import com.github.ai.split.api.response.PutGroupResponse
import com.github.ai.split.api.response.PutMemberResponse
import io.ktor.client.HttpClient

class ApiClient(
Expand Down Expand Up @@ -130,6 +132,17 @@ class ApiClient(
url = "$baseUrl/member/$memberUid?password=$password"
)

suspend fun putMember(
memberUid: String,
password: String,
request: PutMemberRequest
): Either<ApiException, PutMemberResponse> =
httpClient.sendRequest<PutMemberRequest, PutMemberResponse>(
type = RequestType.PUT,
url = "$baseUrl/member/$memberUid?password=$password",
body = Some(request)
)

companion object {
const val PROD_SERVER_URL = "https://api.simplesplitapp.link"
const val DEBUG_SERVER_URL = "http://10.0.2.2:8080"
Expand Down
13 changes: 13 additions & 0 deletions ...d/app/src/main/java/com/github/ai/simplesplit/android/data/repository/MemberRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import arrow.core.Either
import com.github.ai.simplesplit.android.data.api.ApiClient
import com.github.ai.simplesplit.android.model.exception.AppException
import com.github.ai.split.api.request.PostMemberRequest
import com.github.ai.split.api.request.PutMemberRequest
import com.github.ai.split.api.response.DeleteMemberResponse
import com.github.ai.split.api.response.PostMemberResponse
import com.github.ai.split.api.response.PutMemberResponse

class MemberRepository(
private val api: ApiClient
Expand All @@ -28,4 +30,15 @@ class MemberRepository(
memberUid = memberUid,
password = password
)

suspend fun updateMember(
memberUid: String,
password: String,
request: PutMemberRequest
): Either<AppException, PutMemberResponse> =
api.putMember(
memberUid = memberUid,
password = password,
request = request
)
}
48 changes: 29 additions & 19 deletions ...m/github/ai/simplesplit/android/presentation/screens/groupEditor/GroupEditorInteractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ import com.github.ai.split.api.UserNameDto
import com.github.ai.split.api.request.PostGroupRequest
import com.github.ai.split.api.request.PostMemberRequest
import com.github.ai.split.api.request.PutGroupRequest
import com.github.ai.split.api.request.PutMemberRequest

typealias UserUidAndName = Pair<String, String>

class GroupEditorInteractor(
private val groupRepository: GroupRepository,
Expand All @@ -28,29 +31,36 @@ class GroupEditorInteractor(
credentials: GroupCredentials,
newTitle: String?,
newPassword: String?,
membersToRemove: List<String>,
membersToAdd: List<String>
memberUidsToRemove: List<String>,
memberNamesToAdd: List<String>,
membersToUpdate: List<UserUidAndName>
): Either<AppException, GroupDto> =
either {
if (membersToAdd.isNotEmpty()) {
for (member in membersToAdd) {
memberRepository.createMember(
password = credentials.password,
request = PostMemberRequest(
groupUid = credentials.groupUid,
name = member
)
).bind()
}
for (memberName in memberNamesToAdd) {
memberRepository.createMember(
password = credentials.password,
request = PostMemberRequest(
groupUid = credentials.groupUid,
name = memberName
)
).bind()
}

if (membersToRemove.isNotEmpty()) {
for (member in membersToRemove) {
memberRepository.removeMember(
memberUid = member,
password = credentials.password
).bind()
}
for (memberUid in memberUidsToRemove) {
memberRepository.removeMember(
memberUid = memberUid,
password = credentials.password
).bind()
}

for ((memberUid, memberName) in membersToUpdate) {
memberRepository.updateMember(
memberUid = memberUid,
password = credentials.password,
request = PutMemberRequest(
name = memberName
)
).bind()
}

val group = if (newTitle != null ||
Expand Down
Loading