feat: add ~variance~ standard deviation selector#22
feat: add ~variance~ standard deviation selector#22michaelpun wants to merge 11 commits intomainfrom
Conversation
There was a problem hiding this comment.
Thanks for the feature. This is a more exotic use case, but I still think this can be useful for a broader audience and probably an implementation as Selector makes the most sense.
However, I also share your concern that we are not actually 'selecting' a value. A possible solution to this would be to change the name to VarianceAggregation or something similar.
To make the VarianceSelector use the same units as its input, one could also think about returning the standard deviation instead of the variance, if this still fulfills the purpose.
Co-authored-by: Patrick Kunzmann <padix.key@gmail.com>
94613fd to
9ec2f8a
Compare
9ec2f8a to
38e6b4f
Compare
|
Thanks for the feedback!
I think this is a great suggestion. After using the VarianceSelector for a bit, I think having the same units would be good both for the code and for the ease of interpretability on the user's end. I've replaced
I think this could make sense. If I were to rename the now-called |
Would
I would say so. But maybe a third opinion would be good here. @danielkovtun @emalgorithm @dtischer Do you prefer |
This PR adds
VarianceSelectorclass which straightforwardly returns the variance of a metric.From the
Selectorbase class, I think this is within the spirit of the class to return an aggregation of the metric but due to the name "Selector" I wonder if this goes against the spirit due to it no longer having the same units as the original metric.