Various commits for RSpec2/Rails3 compatability#2
Open
timlinquist wants to merge 7 commits intoaiwilliams:masterfrom
Open
Various commits for RSpec2/Rails3 compatability#2timlinquist wants to merge 7 commits intoaiwilliams:masterfrom
timlinquist wants to merge 7 commits intoaiwilliams:masterfrom
Conversation
|
Hi Tim, I've tried to get the (dataset) tests running for your fork but failed didn't get far. Did you get them running and passing? If so, it would be very cool if you could add a Gemfile that would define all dependencies. Jeroen |
|
This is stale. Should we close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been migrating to Rails3 and have a few fixes here. We've been using this fork with these 7 commits on Rails3 for a few weeks now. Everything appears stable so now seemed like a good time to submit a pull request.
Fixes courtesy of @amerine, @srbaker, and myself.