-
Notifications
You must be signed in to change notification settings - Fork 22
added datetime extracted #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xainaz
wants to merge
2
commits into
development
Choose a base branch
from
added-user-info-execution-payload
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| """Helpers for attaching client-side user metadata to execution payloads. | ||
|
|
||
| Copyright 2024 The aiXplain SDK authors | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| """ | ||
|
|
||
| import logging | ||
| from datetime import datetime | ||
| from functools import lru_cache | ||
| from typing import Dict | ||
|
|
||
| import requests | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| _IPINFO_URL = "https://ipinfo.io/json" | ||
| _IPINFO_TIMEOUT = 2.0 | ||
|
|
||
|
|
||
| @lru_cache(maxsize=1) | ||
| def get_user_location() -> Dict[str, str]: | ||
| """Fetch and cache the user's region and country from ipinfo.io.""" | ||
| try: | ||
| response = requests.get(_IPINFO_URL, timeout=_IPINFO_TIMEOUT) | ||
| response.raise_for_status() | ||
| payload = response.json() | ||
| except (requests.RequestException, ValueError) as exc: | ||
| logger.debug("Failed to fetch user location from ipinfo.io: %s", exc) | ||
| return {} | ||
|
|
||
| if not isinstance(payload, dict): | ||
| return {} | ||
|
|
||
| location: Dict[str, str] = {} | ||
|
|
||
| region = payload.get("region") | ||
| if isinstance(region, str) and region.strip(): | ||
| location["region"] = region.strip() | ||
|
|
||
| country = payload.get("country") | ||
| if isinstance(country, str) and country.strip(): | ||
| location["country"] = country.strip() | ||
|
|
||
| return location | ||
|
|
||
|
|
||
| def build_user_info() -> Dict[str, str]: | ||
| """Build user metadata for execution payloads. | ||
|
|
||
| Returns: | ||
| Dict[str, str]: User metadata derived from the local client system. | ||
| """ | ||
| user_info = {"datetime": datetime.now().astimezone().isoformat()} | ||
| user_info.update(get_user_location()) | ||
| return user_info | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xainaz for on prem deployment this will not work. Assume there is no internet connection there. Lets add this as a defensive check if no internet connection keep it empty and do not shre in user info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user doesn't have internet connection they won't be able to run agents anyway right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, they run locally. this is for on prem setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aix-ahmet Will the except here not be enough?
It returns an empty dict if there is any issues in getting the request.