package.json:change sphinxbase install location and specify library location#4
Open
andy5995 wants to merge 2 commits intoajbogh:masterfrom
andy5995:issue_2
Open
package.json:change sphinxbase install location and specify library location#4andy5995 wants to merge 2 commits intoajbogh:masterfrom andy5995:issue_2
andy5995 wants to merge 2 commits intoajbogh:masterfrom
andy5995:issue_2
Conversation
After I made the change to package.json for this commit, I still got an error when I ran `npm install`. I had to run `make clean` in `node_modules/pocketsphinx/`. Then I ran `npm install` again and it worked.
Author
|
I forgot to ping #2 when I made the 2nd commit. This is done. |
Owner
|
Can you help me understand your change a bit, because I want to weigh it with my change which also fixes the problem. My change was to add the The portion of the package.json with the change: Pros to my change:
Cons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #2)