Sourcery Starbot ⭐ refactored ajq2679/saltbot#1
Open
SourceryAI wants to merge 1 commit intoajq2679:mainfrom
Open
Sourcery Starbot ⭐ refactored ajq2679/saltbot#1SourceryAI wants to merge 1 commit intoajq2679:mainfrom
SourceryAI wants to merge 1 commit intoajq2679:mainfrom
Conversation
SourceryAI
commented
Jul 10, 2023
Comment on lines
-26
to
+32
| if len(nickname) == 0: | ||
| if not nickname: | ||
| await ctx.channel.send("um what do you want me to change your name to again?") | ||
| return | ||
| # TODO: Implement error checking for permissions and send to channel if perms are insufficient | ||
| # Force everyone to be a Boi | ||
| separator = " " | ||
| newName = separator.join(nickname) | ||
| newName += " Boi" | ||
| newName = f"{separator.join(nickname)} Boi" |
Author
There was a problem hiding this comment.
Function nickname refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign) - Simplify sequence length comparison (
simplify-len-comparison) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-44
to
+43
| await ctx.channel.send("pongus bongus, latency was " + str(saltBot.latency) + "ms") | ||
| await ctx.channel.send(f"pongus bongus, latency was {str(saltBot.latency)}ms") |
Author
There was a problem hiding this comment.
Function ping refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: