Open
Conversation
Sorseg
commented
May 5, 2024
|
|
||
| // return the stream position from the counting reader object | ||
| Ok(input.stream_position().unwrap()) | ||
| Ok(input.stream_position().unwrap() - (end.bytes().len() as u64)) |
Author
There was a problem hiding this comment.
There is a 50% chance that there is an off-by-one error here
Author
There was a problem hiding this comment.
Also it is weird that we write this to the result but still seek backwards as if it is not read from the source. Is this right?
larstiq
reviewed
May 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses the trick that we don't need to hold on to the last line, since we already have it as a function parameter.