fix: rename accountProtectionRuleSequence.js to lowercase for Linux compatibility#59
Open
gvamsi2010 wants to merge 1 commit intoakamai:masterfrom
Open
Conversation
…ai#58) On case-sensitive filesystems (Linux), Node.js cannot resolve the module because the require path is all-lowercase but the filename is camelCase: require('../../src/accountprotectionrulesequence') → src/accountProtectionRuleSequence.js (not found on Linux) This affects two command files: - bin/commands/accountprotectionruleSequence.js - bin/commands/accountprotectionrulesequence.modify.js Both require '../../src/accountprotectionrulesequence' (lowercase), so renaming the source file to match fixes the issue. All other files in src/ already follow the all-lowercase convention. This was the only file introduced with camelCase (v3.3.0, commit e6afe3e).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #58
Rename
src/accountProtectionRuleSequence.jstosrc/accountprotectionrulesequence.jsto match the all-lowercase convention used by every other file insrc/.Problem
On case-sensitive filesystems (Linux, Docker containers), Node.js cannot resolve the module because the
require()path is all-lowercase but the actual filename is camelCase:This breaks two command files:
bin/commands/accountprotectionruleSequence.jsbin/commands/accountprotectionrulesequence.modify.jsError:
This works on macOS (case-insensitive filesystem) but fails on Linux (ext4/xfs).
Fix
A single file rename — no code changes. The file was the only one in
src/introduced with camelCase (v3.3.0, commit e6afe3e). All other ~75 files insrc/already use all-lowercase naming.Note on PR #56
PR #56 takes the opposite approach (changing require paths to match the camelCase filename). That would still break because
bin/commands/accountprotectionruleSequence.jsitself has mixed casing — the Akamai CLI loads command files frombin/commands/by scanning the directory, and the lowercase convention is what the rest of the codebase follows.