Open
Conversation
The code that enables publishing notifications is spread across several code paths. Instead of checking for the toggle flag at every point or in the Publisher class itself we replace the Publisher class with a NoopPublisher class which simply stubs out the methods and does nothing. This allows us to configure and declare the behaviour in main.py without spreading more conditionals all over the place.
Renames the option to 'topic'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a configuration group named, "ceilometer," and a boolean toggle to enable publishing notifications to the ceilometer queue. It defaults to "False" which makes the notifications.Publisher a no-op class since it is passed around to several areas of the code and none of which relies on return values of side-effects of calling methods on it.