Add leaderboard to initial welcome screen#57
Open
akshayravikumar wants to merge 1 commit intomasterfrom
Open
Conversation
Testing Copilot workspace --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/akshayravikumar/TeXnique?shareId=XXXX-XXXX-XXXX-XXXX).
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 0b872c4 in 1 minute and 44 seconds
More details
- Looked at
60lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. public/assets/js/index.js:89
- Draft comment:
loadTopScoresThisMonthis defined twice. Remove the duplicate definition to avoid redundancy. - Reason this comment was not posted:
Marked as duplicate.
2. public/assets/js/index.js:349
- Draft comment:
loadTopScoresThisMonthis defined twice. Remove the duplicate definition to avoid redundancy. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_w8HHW9CGC9eciLio
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| } | ||
| } | ||
|
|
||
| async function loadTopScoresThisMonth() { |
There was a problem hiding this comment.
This is a duplicate of the existing loadLeaderboard function which already supports monthly filtering via timeRange='month'. Consider extending the existing function with parameters for limit and target element instead of creating a new one.
- function
loadLeaderboard(index.js)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Monthly Top Scores Leaderboard to Welcome Screen
This PR adds a new feature to display the top 5 scores from the current month on the welcome screen.
Changes
loadTopScoresThisMonth()function that queries the leaderboard collection for scores from the current monthshowIntro()to call the new function when the welcome screen is displayedImplementation Details