Add some statistics formulas to problem.js#60
Open
ddavidd23 wants to merge 1 commit intoakshayravikumar:masterfrom
Open
Add some statistics formulas to problem.js#60ddavidd23 wants to merge 1 commit intoakshayravikumar:masterfrom
ddavidd23 wants to merge 1 commit intoakshayravikumar:masterfrom
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5cd32af in 1 minute and 19 seconds. Click for details.
- Reviewed
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. public/assets/js/problems.js:915
- Draft comment:
The PR description lists the Ridge Regression formula as Cartan's magic formula, but the code uses a different (and correct) expression. Please update the PR description to match the code. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to update the PR description, which is against the rules. The focus should be on the code itself, not the PR description.
2. public/assets/js/problems.js:916
- Draft comment:
Consider clarifying the notation in the Ridge Regression formula (e.g. using explicit multiplication '\�5{X}\mathbf{w}' if desired) for consistency. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_w8ld9GVBKBn3zUw6
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following three statistics-related formulas which have interesting LaTeX formulas:
Important
Add Ridge Regression, ELBO, and Langevin Dynamics formulas to
problems.js.problems.js:This description was created by
for 5cd32af. You can customize this summary. It will automatically update as commits are pushed.