Add support for custom event instead of 'click'#15
Open
danielgranat wants to merge 5 commits intoakveo:masterfrom
Open
Add support for custom event instead of 'click'#15danielgranat wants to merge 5 commits intoakveo:masterfrom
danielgranat wants to merge 5 commits intoakveo:masterfrom
Conversation
…a click-in-progress
…a click-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I recently needed to change the flow when a user clicks on the progress button, and before starting the progress the user needs to confirm the action he is about to make. To allow this i added another optional attribute for custom-event, in which case instead of binding to the click event, i bind to the custom event.
After the change, by button html looks like this:
My submit click function looks like this:
Another change i had to make to support this is when an event is triggered, to change the $scope.apply() to $timeout, because a digest may already be in progress.
What do you think?