Closed
Conversation
Owner
|
Sorry so much for my lateness! Finally I tested in my local environment. I checked what the changes wants to do. I think its not bad. Then, just I want to ask, do you think this fliping player model should use Animator that parcool provides? Othe all parcool animations are implemented as Animator, even ones including model rotation, so for me thinking it is good to keep consistency. |
Author
|
Sure, no problem. |
Merged
Author
|
This PR needs to be closed because #462 provides a better implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this mod, after performing a slide action, the player plays a getting-up animation.
However, the player currently stands up facing forward, which looks quite unnatural.
This PR fixes the issue by toggling a flag according to the animation flow and flipping the player's pose angle to correct the getting-up direction.