Add Github actions for linting and testing #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23 and #43.
This PR adds a simple .yml workflow for linting and testing the code prior to merging with main.
The workflow is a Development one, but idk whether we would need Staging/Production CI logic on this project haha.
For now, it works only on main commits + on PRs headed towards main.
There is no problem in extending these triggers in the future btw.
You can see the example of such Action right in this PR in my fork. Don't pay attention to the failing checks, for now this is caused by #46.
But, I guess, after completing this PR and resolving linting issues, it will be great to prohibit merges on failed CI/CD in project settings.