Skip to content

add continents#113

Open
schoenbergerb wants to merge 1 commit intoalcohol:mainfrom
schoenbergerb:main
Open

add continents#113
schoenbergerb wants to merge 1 commit intoalcohol:mainfrom
schoenbergerb:main

Conversation

@schoenbergerb
Copy link

Hi,

while working on a new feature, I ran into a scenario where filtering countries by continent was essential. To address this need, I've updated the ISO3166 dataset by adding a continent field to every country. This change allows for more precise geographical grouping without affecting existing functionality.

I hope makes sense from your perspective ✌️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@38a9ead). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #113   +/-   ##
========================================
  Coverage        ?   100.00%           
  Complexity      ?        39           
========================================
  Files           ?         4           
  Lines           ?       100           
  Branches        ?         0           
========================================
  Hits            ?       100           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alcohol
Copy link
Owner

alcohol commented Jun 5, 2025

Should this not take into account that there are several countries that actually span multiple continents? Such as Russia, Turkey, etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants