Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
========================================
Coverage ? 100.00%
Complexity ? 39
========================================
Files ? 4
Lines ? 100
Branches ? 0
========================================
Hits ? 100
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Owner
|
Should this not take into account that there are several countries that actually span multiple continents? Such as Russia, Turkey, etc? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
while working on a new feature, I ran into a scenario where filtering countries by continent was essential. To address this need, I've updated the ISO3166 dataset by adding a continent field to every country. This change allows for more precise geographical grouping without affecting existing functionality.
I hope makes sense from your perspective ✌️