Open
Conversation
…rom the aura node
Owner
|
Hello! thank you for contributing to Thavma! Also important note, this will have conflicts with the upcoming version 0.13 which is its own branch, because you based it off of master. This should merge into 0.13 ideally |
alegian
requested changes
Mar 12, 2026
Owner
There was a problem hiding this comment.
i believe this should be datagened automatically
| CompositeState.builder() | ||
| .setShaderState(RenderStateShard.POSITION_COLOR_SHADER) | ||
| .setTransparencyState(RenderStateShard.TRANSLUCENT_TRANSPARENCY) | ||
| .setTransparencyState(RenderStateShard.LIGHTNING_TRANSPARENCY) |
Owner
There was a problem hiding this comment.
the additions in this file do nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor change concerning the visual part of the viz-node, as well as the animation of sucking aspects out of it (and the aspect path in general). Now it is closer to the original version, but we haven't managed to make the aspect path the same yet, but it's definitely better than it was before.
This is more relevant to this issue: #22