Resolve redirects when testing URLs for equality #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make DOI uppercase always. * add docs to `get_real_url_from_doi`. * remove types (will add back with typing) * added API to generated docs.
Remove superfluous Exception handling and overlapping 404 exception.
hseg
force-pushed
the
canonicalize_urls
branch
4 times, most recently
from
289b398 to
c67beee
Compare
|
Note the PR is based on the https://github.com/papis/python-doi master, which hasn't been merged here -- merging this PR would do that as well. I'm not sure what the relation is between these two repositories, so I opened the PR in both. |
The URL DOIs resolve to can move around, with redirects pointing to the new location. To make the tests more robust, only fail if the URLs differ after redirections. See also https://www.crossref.org/blog/urls-and-dois-a-complicated-relationship/
hseg
force-pushed
the
canonicalize_urls
branch
3 times, most recently
from
7cfe04a to
b161e62
Compare
Also put in a fallback using requests, but it is hacky and only works sometimes. cloudscraper stands a better chance of consistently being able to get to the final URL
This eg makes it easier to spot which particular iteration breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL DOIs resolve to can move around, with redirects pointing to the new location. To make the tests more robust, only fail if the URLs differ after redirections.
See: https://www.crossref.org/blog/urls-and-dois-a-complicated-relationship/ and item 10 on https://pardalotus.tech/posts/2024-10-02-falsehoods-programmers-believe-about-dois/