fix(discord): greeting-prefixed messages misclassified as questions#2162
Merged
alekspetrov merged 1 commit intomainfrom Mar 13, 2026
Merged
fix(discord): greeting-prefixed messages misclassified as questions#2162alekspetrov merged 1 commit intomainfrom
alekspetrov merged 1 commit intomainfrom
Conversation
Messages like "Hello! How is it going?" were treated as codebase questions because IsClearQuestion (ends with ?) fired before greeting detection in comms.Handler.detectIntent(). Added StartsWithGreeting() check before the question fast path so greeting-prefixed messages get the greeting response instead of "Looking into that...". Closes #2159, #2160, #2161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsClearQuestion()fast path (matches?suffix) fired before greeting detection incomms.Handler.detectIntent()intent.StartsWithGreeting()— detects messages starting with greeting words (hi, hello, hey, good morning, etc.) up to 10 wordsTest plan
TestStartsWithGreeting— 17 cases covering single-word, multi-word, punctuation, non-greetings, edge cases@Pilot Hello! How is it going?in Discord → should get greeting responseCloses #2159, #2160, #2161