This repository was archived by the owner on Jun 11, 2024. It is now read-only.
Trigger testnet & mainnet deployments with tags #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mvaivre @killerwhile I look forward to hear your thoughts on this proposal.
Problem
How do I know which frontend version is running on mainnet and on testnet? How do I know what was last deployed? The actions logs don't show me this information when deploying a branch (usually master) and not a tag, and even if it's a tag that is deployed, I have to dig that out from the logs of the last executed action.
Proposal 1
Similarly to how we trigger the "sign and release" workflow by pushing a tag that matches a regex in the desktop wallet, I am proposing that our "deploy to [mainnet|testnet]" workflows also get triggered by tags. Specifically, I propose:
v1.2.3v1.2.3-rc.0Concerns
It's true that the "sign and release" workflow is less impactful. It creates a draft release. Nothing gets published until I explicitly edit the draft release and publish it. Whereas in the case of the explorer, things get deployed on public services.
Proposal 2
We figure out how to restrict the manual triggering amongst the tag options (aka: not be able to trigger the workflows on a branch but only on a tag. This doc page might have more info on how to do that: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
On top of the above approaches, I think it'd be useful to have a small
v1.2.3text somewhere at the footer of the app:I am open to your feedback and to discuss my approach and/or alternative approaches!