test: add hive_lib, unit and smoke tests by alexandremattioli · Pull Request #6 · alexandremattioli/Build

alexandremattioli · 2025-11-08T02:00:14Z

Adds:

scripts/bootstrap/ubuntu24/hive_lib.py for isolated role suggestion and signing helpers
Unit tests for role suggestion and HMAC signing/validation
Smoke tests: py_compile of key scripts and advisor --help, message bridge invocation
pyproject.toml configuring pytest addopts
scripts/test/run_tests.sh convenience runner

CI workflow deferred due to path creation issues (.github/workflows 404) — recommend creating directory and adding workflow next.

All tests pass locally (module-level compile + logic assertions).

Follow-ups:

Introduce .github/workflows/tests.yml once directory availability confirmed
Expand smoke tests to simulate IDENTIFY -> ADVICE roundtrip with ephemeral sockets
Add negative tests for malformed envelopes.

… unit tests

…mplementation checklist

Copilot

Pull Request Overview

This PR introduces a test infrastructure for the build hive system, adding unit tests for cryptographic signing/validation and role suggestion logic, along with smoke tests for script compilation.

Extracts shared utilities into hive_lib.py for testability
Adds comprehensive unit tests for message signing and CloudStack role assignment
Includes smoke tests to validate script compilation and basic functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
scripts/bootstrap/ubuntu24/hive_lib.py	New shared library extracting role suggestion and message signing/validation logic for unit testing
tests/test_hive_lib_signing.py	Unit tests for HMAC-SHA256 message signing and validation, including tampering detection
tests/test_hive_lib_roles.py	Unit tests for CloudStack role suggestion logic based on peer configuration
tests/smoke/test_smoke_scripts.py	Smoke tests verifying Python script compilation and basic execution
tests/init.py	Test package marker file
pyproject.toml	Project configuration with pytest settings and Python path configuration
scripts/test/run_tests.sh	Test runner script for automated test execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-08T02:03:56Z

+
+
+def test_vnf_tester_when_broker_available():
+    peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]


Inconsistent spacing in list literal. Remove spaces after [ and before ] for consistency with PEP 8: [{'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'}].

Suggested change

peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]

peers = [{'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'}]

Copilot · 2025-11-08T02:03:56Z

+            'packages': ['mysql-server','nfs-kernel-server','openjdk-17-jdk','git'],
+            'config': {'db': 'mysql', 'nfs': True},
+            'reason': 'First management server needed'
+        }
+    if roles.get('cloudstack-builder', 0) < 2:
+        return {
+            'role': 'cloudstack-builder',
+            'packages': ['openjdk-17-jdk','maven','git','build-essential'],
+            'config': {'build_threads': 8},
+            'reason': 'Increase build capacity'
+        }
+    if roles.get('kvm-hypervisor', 0) == 0:
+        return {
+            'role': 'kvm-hypervisor',
+            'packages': ['qemu-kvm','libvirt-daemon-system','bridge-utils'],
+            'config': {'virt_network': 'default'},
+            'reason': 'Provide hypervisor for functional tests'
+        }
+    if vnf_available and roles.get('vnf-tester', 0) == 0:
+        return {
+            'role': 'vnf-tester',
+            'packages': ['python3-requests','docker.io'],
+            'config': {'broker_port': 8443},
+            'reason': 'Validate VNF broker operations'
+        }
+    return {
+        'role': 'test-runner',
+        'packages': ['python3-pytest','curl','git'],


Missing spaces after commas in list literal. Per PEP 8, add spaces after commas: ['mysql-server', 'nfs-kernel-server', 'openjdk-17-jdk', 'git'].

Suggested change

'packages': ['mysql-server','nfs-kernel-server','openjdk-17-jdk','git'],

'config': {'db': 'mysql', 'nfs': True},

'reason': 'First management server needed'

}

if roles.get('cloudstack-builder', 0) < 2:

return {

'role': 'cloudstack-builder',

'packages': ['openjdk-17-jdk','maven','git','build-essential'],

'config': {'build_threads': 8},

'reason': 'Increase build capacity'

}

if roles.get('kvm-hypervisor', 0) == 0:

return {

'role': 'kvm-hypervisor',

'packages': ['qemu-kvm','libvirt-daemon-system','bridge-utils'],

'config': {'virt_network': 'default'},

'reason': 'Provide hypervisor for functional tests'

}

if vnf_available and roles.get('vnf-tester', 0) == 0:

return {

'role': 'vnf-tester',

'packages': ['python3-requests','docker.io'],

'config': {'broker_port': 8443},

'reason': 'Validate VNF broker operations'

}

return {

'role': 'test-runner',

'packages': ['python3-pytest','curl','git'],

'packages': ['mysql-server', 'nfs-kernel-server', 'openjdk-17-jdk', 'git'],

'config': {'db': 'mysql', 'nfs': True},

'reason': 'First management server needed'

}

if roles.get('cloudstack-builder', 0) < 2:

return {

'role': 'cloudstack-builder',

'packages': ['openjdk-17-jdk', 'maven', 'git', 'build-essential'],

'config': {'build_threads': 8},

'reason': 'Increase build capacity'

}

if roles.get('kvm-hypervisor', 0) == 0:

return {

'role': 'kvm-hypervisor',

'packages': ['qemu-kvm', 'libvirt-daemon-system', 'bridge-utils'],

'config': {'virt_network': 'default'},

'reason': 'Provide hypervisor for functional tests'

}

if vnf_available and roles.get('vnf-tester', 0) == 0:

return {

'role': 'vnf-tester',

'packages': ['python3-requests', 'docker.io'],

'config': {'broker_port': 8443},

'reason': 'Validate VNF broker operations'

}

return {

'role': 'test-runner',

'packages': ['python3-pytest', 'curl', 'git'],

Copilot · 2025-11-08T02:03:57Z

+    if vnf_available and roles.get('vnf-tester', 0) == 0:
+        return {
+            'role': 'vnf-tester',
+            'packages': ['python3-requests','docker.io'],


Missing spaces after commas in list literal. Per PEP 8, add spaces after commas: ['python3-requests', 'docker.io'].

Suggested change

'packages': ['python3-requests','docker.io'],

'packages': ['python3-requests', 'docker.io'],

Copilot · 2025-11-08T02:03:57Z

+    sig = message.get('sig', '')
+    if not isinstance(pl, dict):
+        return False
+    raw = json.dumps(pl, separators=(',',':')).encode('utf-8')


Missing space after comma in tuple literal. Per PEP 8, add space after comma: separators=(',', ':').

Suggested change

raw = json.dumps(pl, separators=(',',':')).encode('utf-8')

raw = json.dumps(pl, separators=(', ', ':')).encode('utf-8')

Copilot · 2025-11-08T02:03:57Z

+
+def test_sign_and_valid_roundtrip():
+    pl = make_payload()
+    raw = json.dumps(pl, separators=(',',':')).encode('utf-8')


Missing space after comma in tuple literal. Per PEP 8, add space after comma: separators=(',', ':').

Copilot · 2025-11-08T02:03:58Z

+    if roles.get('cloudstack-builder', 0) < 2:
+        return {
+            'role': 'cloudstack-builder',
+            'packages': ['openjdk-17-jdk','maven','git','build-essential'],


Missing spaces after commas in list literal. Per PEP 8, add spaces after commas: ['openjdk-17-jdk', 'maven', 'git', 'build-essential'].

Suggested change

'packages': ['openjdk-17-jdk','maven','git','build-essential'],

'packages': ['openjdk-17-jdk', 'maven', 'git', 'build-essential'],

Copilot · 2025-11-08T02:03:58Z

+    if roles.get('kvm-hypervisor', 0) == 0:
+        return {
+            'role': 'kvm-hypervisor',
+            'packages': ['qemu-kvm','libvirt-daemon-system','bridge-utils'],


Missing spaces after commas in list literal. Per PEP 8, add spaces after commas: ['qemu-kvm', 'libvirt-daemon-system', 'bridge-utils'].

Suggested change

'packages': ['qemu-kvm','libvirt-daemon-system','bridge-utils'],

'packages': ['qemu-kvm', 'libvirt-daemon-system', 'bridge-utils'],

Copilot · 2025-11-08T02:03:58Z

+        }
+    return {
+        'role': 'test-runner',
+        'packages': ['python3-pytest','curl','git'],


Missing spaces after commas in list literal. Per PEP 8, add spaces after commas: ['python3-pytest', 'curl', 'git'].

Suggested change

'packages': ['python3-pytest','curl','git'],

'packages': ['python3-pytest', 'curl', 'git'],

Copilot · 2025-11-08T02:03:59Z

+
+def test_invalid_magic():
+    pl = make_payload()
+    raw = json.dumps(pl, separators=(',',':')).encode('utf-8')


Missing space after comma in tuple literal. Per PEP 8, add space after comma: separators=(',', ':').

Copilot · 2025-11-08T02:03:59Z

+    peers = [ {'role': 'management-server'} ]
+    advice = suggest_cloudstack_role(peers)
+    assert advice['role'] == 'cloudstack-builder'
+    assert 'maven' in advice['packages']
+
+
+def test_hypervisor_after_two_builders():
+    peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'} ]
+    advice = suggest_cloudstack_role(peers)
+    assert advice['role'] == 'kvm-hypervisor'
+    assert 'qemu-kvm' in advice['packages']
+
+
+def test_vnf_tester_when_broker_available():
+    peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]


Inconsistent spacing in list literals. Lines 12, 19, and 26 have spaces after [ and before ] (e.g., [ {...} ]), while line 5 uses no spaces ([]). For consistency with PEP 8 and the multi-line list at lines 33-39, remove the extra spaces: [{'role': 'management-server'}].

Suggested change

peers = [ {'role': 'management-server'} ]

advice = suggest_cloudstack_role(peers)

assert advice['role'] == 'cloudstack-builder'

assert 'maven' in advice['packages']

def test_hypervisor_after_two_builders():

peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'} ]

advice = suggest_cloudstack_role(peers)

assert advice['role'] == 'kvm-hypervisor'

assert 'qemu-kvm' in advice['packages']

def test_vnf_tester_when_broker_available():

peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]

peers = [{'role': 'management-server'}]

advice = suggest_cloudstack_role(peers)

assert advice['role'] == 'cloudstack-builder'

assert 'maven' in advice['packages']

def test_hypervisor_after_two_builders():

peers = [{'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}]

advice = suggest_cloudstack_role(peers)

assert advice['role'] == 'kvm-hypervisor'

assert 'qemu-kvm' in advice['packages']

def test_vnf_tester_when_broker_available():

peers = [{'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'}]

alexandremattioli added 7 commits November 8, 2025 02:58

test: add tests package init

ffca66d

feat(test): add hive_lib with role suggestion and signing helpers for…

351d30e

… unit tests

test: add unit tests for hive_lib role suggestion

5217e56

test: add unit tests for hive_lib signing/validation

7b81cbe

test: add smoke tests for script compilation and basic CLI

0b62039

chore(test): add pyproject for pytest options

31d9ff6

chore(test): add local runner script for tests

f829299

Copilot AI review requested due to automatic review settings November 8, 2025 02:00

docs(methodology): embed formal test categories, quality gates, and i…

c9cf37b

…mplementation checklist

Copilot AI reviewed Nov 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add hive_lib, unit and smoke tests#6

test: add hive_lib, unit and smoke tests#6
alexandremattioli wants to merge 8 commits intofeature/ubuntu24-bootstrapfrom
feature/hive-tests

alexandremattioli commented Nov 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Copilot AI Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def test_vnf_tester_when_broker_available():
		peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]

	peers = [ {'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'} ]
	peers = [{'role': 'management-server'}, {'role': 'cloudstack-builder'}, {'role': 'cloudstack-builder'}, {'role': 'kvm-hypervisor'}]

	'packages': ['python3-requests','docker.io'],
	'packages': ['python3-requests', 'docker.io'],

	raw = json.dumps(pl, separators=(',',':')).encode('utf-8')
	raw = json.dumps(pl, separators=(', ', ':')).encode('utf-8')

	'packages': ['openjdk-17-jdk','maven','git','build-essential'],
	'packages': ['openjdk-17-jdk', 'maven', 'git', 'build-essential'],

	'packages': ['qemu-kvm','libvirt-daemon-system','bridge-utils'],
	'packages': ['qemu-kvm', 'libvirt-daemon-system', 'bridge-utils'],

	'packages': ['python3-pytest','curl','git'],
	'packages': ['python3-pytest', 'curl', 'git'],

Conversation

alexandremattioli commented Nov 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants