Add cppcheck marker to collected items for -m filtering#12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes pytest-cppcheck’s collected cppcheck test item selectable via pytest’s -m marker filtering by registering and applying a cppcheck marker.
Changes:
- Register a
cppcheckmarker inpytest_configureto avoid unknown-marker warnings. - Add the
cppcheckmarker to the collectedCppcheckItemso-m cppcheck/-m 'not cppcheck'filtering works.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+66
| item = CppcheckItem.from_parent(self, name="CPPCHECK") | ||
| item.add_marker(pytest.mark.cppcheck) | ||
| yield item |
There was a problem hiding this comment.
New behavior adds a cppcheck marker so users can filter with -m cppcheck, but there’s no test asserting that marker-based selection works (e.g., pytest --cppcheck -m cppcheck runs the item, and pytest --cppcheck -m 'not cppcheck' deselects it). Please add a pytester test to cover the marker filtering to prevent regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.