Fonts were clipping for me so I added preloading#2
Open
heyJordanParker wants to merge 1 commit intoalexknowshtml:mainfrom
Open
Fonts were clipping for me so I added preloading#2heyJordanParker wants to merge 1 commit intoalexknowshtml:mainfrom
heyJordanParker wants to merge 1 commit intoalexknowshtml:mainfrom
Conversation
document.fonts.load() resolves when fonts are downloaded but canvas measureText() may still return fallback font metrics. Chain document.fonts.ready and verify with document.fonts.check() in a requestAnimationFrame retry loop before calling convertToExcalidrawElements. Fixes text clipping in labeled shapes and standalone text elements.
Author
|
How they looked before: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing this by hand like a dork, but yes.
Font size is hardcoded right now, which isn't ideal, but it does work so you might want it.
I'm using it alongside a modified version of your skill.
document.fonts.load() resolves when fonts are downloaded but canvas measureText() may still return fallback font metrics. Chain document.fonts.ready and verify with document.fonts.check() in a requestAnimationFrame retry loop before calling convertToExcalidrawElements.
Fixes text clipping in labeled shapes and standalone text elements.