feat: filter .md filename false positives from tweet URL processing#25
Open
rymalia wants to merge 1 commit intoalexknowshtml:mainfrom
Open
feat: filter .md filename false positives from tweet URL processing#25rymalia wants to merge 1 commit intoalexknowshtml:mainfrom
rymalia wants to merge 1 commit intoalexknowshtml:mainfrom
Conversation
Detect when Twitter auto-links bare filenames like CLAUDE.md or plan.md to Moldova's .md ccTLD and classify them as 'filename-reference' instead of fetching content from parked/unrelated domains. Detection logic: bare .md root domain that isn't obsidian.md (the only known legitimate .md domain in tech Twitter), has no subdomain, and has no meaningful path. Integrated as a branch in the existing URL type classification chain.
blu3dot
approved these changes
Feb 15, 2026
blu3dot
left a comment
blu3dot
left a comment
There was a problem hiding this comment.
Banneker Architecture Review ✅
Clean, well-scoped fix:
- Pure
isLikelyMdFilename()function — testable, no side effects - Properly integrates into existing URL type classification chain
- Allowlist pattern (obsidian.md) is extensible for future legitimate .md domains
- Good test coverage covering edge cases (subdomains, paths, query params)
- Safe defaults: only filters bare root domains
Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when Twitter auto-links bare filenames like CLAUDE.md or plan.md to Moldova's .md ccTLD and classify them as 'filename-reference' instead of fetching content from parked/unrelated domains (which leads to junk in the knowledge collection.
Detection logic: bare .md root domain that isn't obsidian.md (the only known legitimate .md domain in tech Twitter), has no subdomain, and has no meaningful path. Integrated as a branch in the existing URL type classification chain.