Skip to content

- Fix compilation on OSX using clang-3.8#4

Open
rperrot wants to merge 1 commit intoalexlocher:masterfrom
rperrot:master
Open

- Fix compilation on OSX using clang-3.8#4
rperrot wants to merge 1 commit intoalexlocher:masterfrom
rperrot:master

Conversation

@rperrot
Copy link
Copy Markdown

@rperrot rperrot commented Aug 11, 2016

Here is a simple fix used to enhance compilation on compliant platforms.

There are three fixes :

  • the first one is to force using your cmake/FindEigen instead of the system one ;
  • the second one is to use the -std=c++11 as a cmake macro (this enhance portability)
  • the third ones are just two missing includes.

Note : I didn't fix one thing : the include <omp.h> in main.cpp. If the target doesn't have openmp (which is the default on clang shipped with Xcode), this cause a compilation error. You may indicate to the user that you require openmp or use #ifdef/#define to prevent missing include.

Hope it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant