feat: introduce adapter config for platform-specific configuration options #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'm ok with the API breakage. I'd like to see the Linux and Windows versions of |
Contributor
Author
|
@alexmoon Ready for review. I don't have a linux/windows host to test on right now. |
alexmoon
reviewed
Jul 2, 2025
alexmoon
reviewed
Jul 3, 2025
src/adapter.rs
Outdated
Comment on lines
23
to
35
| /// Creates an interface to the default Bluetooth adapter for the system. | ||
| #[cfg(not(target_os = "android"))] | ||
| pub async fn default() -> Result<Self> { | ||
| sys::adapter::AdapterImpl::default().await.map(Adapter) | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Sorry, I wasn't clear. I want to keep this method but change it to:
pub async fn default() -> Result<Self> {
sys::adapter::AdapterImpl::with_config(AdapterConfig::default()).await.map(Adapter)
}
Owner
|
@lulf are you still working on this? The clippy errors should be resolved by rebasing on main. |
alexmoon
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks the public API a bit, let me know if it should be preserved. Also I put unsafe on creating the config on android, this way the with_config on the adapter could still be the same for all platforms.