Skip to content

Conversation

@abezukor
Copy link
Contributor

There is a clippy warning in rust 1.89 that is cause all of android CI to fail. (https://github.com/alexmoon/bluest/actions/runs/17018037851/job/48243206290?pr=39)

The error is in autogenerated code, so I think it should just be supressed.

There is a clippy warning in rust 1.89 that is cause all of android CI
to fail. (https://github.com/alexmoon/bluest/actions/runs/17018037851/job/48243206290?pr=39)

The error is in autogenerated code, so I think it should just be
supressed.
@abezukor abezukor mentioned this pull request Aug 17, 2025
@alexmoon
Copy link
Owner

I would prefer for java-spaghetti to add the allow during bindings generation. Can you make a PR on that project and then regenerate the bindings?

@wuwbobo2021
Copy link
Contributor

wuwbobo2021 commented Aug 18, 2025

@abezukor I shall tell you the (kind of embarrassing) fact that the main branch of java-spaghetti has switched to use the nightly Rust with the arbitrary_self_types feature enabled, see Dirbaio/java-spaghetti#1. I'm almost not bothered by this issue in #40, thus I can't understand @Dirbaio's meaning of "changing everything again after the feature is stabilized". Currently it just declares #![allow(clippy::all)] at the header of the binding module.

In #31, @alexmoon said he prefer to wait for stabilization of that feature before updating java-spaghetti. I'm not sure of whether @Dirbaio is willing to make any backport for java-spaghetti 0.2, See Dirbaio/java-spaghetti#11.

I guess this can be merged as a workaround before a new version of java-spaghetti is released.

@alexmoon alexmoon merged commit 2c59e09 into alexmoon:main Aug 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants