Code Review I #1
Open
Dlex925 wants to merge 2 commits intoalexremus26:sfml3from
Open
Conversation
Removed the running variable as it can entirely be replaced with window.close() optimizing the while loop at line 395.
Bug:
You can go up to number 9 on the "Currently selected item" no matter the number of existing items.
Solution:
Changed line 414 to select the biggest index with an existing item when choosing an out of bounds item, also fixed the displayed text to say "Use [1-biggest_existing_index]"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review I: Removed unnecessary
runningvariable and fixed out-of-bounds item selectionChanges
runningvariable, it was redundant and replaceable withwindow.close()- optimizing the while loop at line 395.Bug
Fix