File uploader was not handling stream object properly alexwhitman/nod…#50
Open
davidnewcomb wants to merge 1 commit intoalexwhitman:masterfrom
Open
File uploader was not handling stream object properly alexwhitman/nod…#50davidnewcomb wants to merge 1 commit intoalexwhitman:masterfrom
davidnewcomb wants to merge 1 commit intoalexwhitman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pushes.js#70 you have:
I think something has changed here.
formData.append(name, x)expects a string here sofs.createReadStream(filePath)istoString()'ed to "[object Object]" and that is what the body of the request is.There are some differences between native
FormDataandnode-fetchFormData` and I think there might be some confusion here.I have removed the streaming component part and replaced it with what was on the node-fetch website for handling file uploads using the
Fileobject. Now it works and I can see my pictures in the app.When I was trying to get it to work last time there was also an issue with the file path not being found. I think that was something to do with streams not really knowing where they are from. Anyway, it only worked before if I didn't add a path to the file e.g. '1-jack.jpg' worked but '/path/to/1-jack.jpg' did not work. That appears to be fixed too (with this implementation).
Related to #49