Open
Conversation
A simple optimization (in my opinion): i removed anchor tag from fullscreen button definition and event listener.
Owner
|
1 Nested anchors i use for the example |
Contributor
Author
|
@alfredobarron ok for listeners, now i understand. I'll add the listners. About the "lite" code/template (removing anchor tag), i think that this is better because user is free to use his code for button: user can choose about style, position, parent with fewer restrictions. P.S.: please, update example in doc removing anchor :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple optimization (in my opinion): i removed anchor tag from fullscreen button definition and event listeners.
In this commit i want to:
A working example at http://codepen.io/anon/pen/gpZRar