Conversation
xnorpx
commented
Jan 1, 2026
src/change/direct.rs
Outdated
| self.rtc.dtls.local_fingerprint() | ||
| } | ||
|
|
||
|
|
xnorpx
commented
Jan 1, 2026
| /// rtc.direct_api().set_sctp_config(sctp_config); | ||
| /// rtc.direct_api().start_sctp(false); // server with out-of-band signaling | ||
| /// ``` | ||
| pub fn set_sctp_config(&mut self, config: SctpConfig) { |
Collaborator
Author
There was a problem hiding this comment.
maybe return error if we already have a config?
xnorpx
commented
Jan 1, 2026
| tracing = "0.1.37" | ||
| fastrand = "2.0.1" | ||
| sctp-proto = "0.6.0" | ||
| #sctp-proto = "0.7.0" |
Collaborator
Author
There was a problem hiding this comment.
Update this once sctp-change is in
xnorpx
commented
Jan 1, 2026
| with: | ||
| check_diff: true | ||
| line_width_rules: 'CHANGELOG.md:120;c_cpp_properties.json:160;Cargo.toml:150;README.md:180;README.tpl:180;*.md:110;*.rs:110;*.toml:110;DEFAULT=110' | ||
| # snowflake: |
Collaborator
Author
There was a problem hiding this comment.
revert once sctp changes is in
xnorpx
force-pushed
the
dev/direct_snap
branch
from
619c4bb to
3b2ddbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.