fix(ice): filter out discarded candidates#865
Merged
thomaseizinger merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
thomaseizinger
commented
Feb 13, 2026
When a local or remote candidate gets invalidated, str0m internally sets a `discarded` flag instead of removing the `Candidate`. This allows us to retain the indices into the `local_candidates` and `remote_candidates` lists. Unfortunately, with the current getters of `local_candidates` and `remote_candidates`, this implementation detail leaks through because those discarded candidates still get returned there. In order to provide a consistent view of the world to the user, we change the API to return an Iterator instead and filter the candidates by the `discarded` flag.
thomaseizinger
force-pushed
the
fix/filter-discarded-candidates
branch
from
9e63581 to
f78b99b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a local or remote candidate gets invalidated, str0m internally sets a
discardedflag instead of removing theCandidate. This allows us to retain the indices into thelocal_candidatesandremote_candidateslists.Unfortunately, with the current getters of
local_candidatesandremote_candidates, this implementation detail leaks through because those discarded candidates still get returned there.In order to provide a consistent view of the world to the user, we change the API to return an
Iteratorinstead and filter the candidates by thediscardedflag.