Open
Conversation
Collaborator
|
@algesten I think it looks resonable. But this would not work if we had if a user brought their own RTP header extension? |
Owner
What do you mean? |
Collaborator
let mut pkt_ext_vals = ext_vals.clone();
if !first {
pkt_ext_vals.user_values.remove::<VideoLayersAllocation>();
}I read it as it will remove VideoLayesAllocation if it's not the first package. If I create my own say DD header extension which should also only be on the first packet (similar to VLA) I do not contribute this back to str0m, how can I avoid to get it attached to all packets in the frame? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @algesten,
At the moment, VLA is added to every packet in a frame. However, based on the libwebrtc implementation, it should only be included in the first packet of the frame. This PR fixes that behavior