✅Added logs and defensively throw an error when stale session detected#298
Open
ericsharma wants to merge 2 commits intodevelopmentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atrefonas
suggested changes
Sep 15, 2022
Contributor
atrefonas
left a comment
atrefonas
left a comment
There was a problem hiding this comment.
Looks good just needs the remote logging as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
Added logs related to the connector instance and for the Session Storage that walletconnect independently injects into our app.
The first defensive error I implemented was the simplest: Checking to see if walletconnect session is connected.
This could resolve the issue entirely, but if it doesn't then it also gives us an analytical starting point to identify the mismatches between the
thisconnector and thewalletConnectSessionStorageinformation. Different handshake topics etc....📝 Related Issues
#297