✅301 acceptance standardize cut order logic#329
Open
ericsharma wants to merge 14 commits intomainfrom
Hidden character warning
The head ref may contain hidden characters: "\u2705301-acceptance-standardize-cut-order-logic"
Open
Conversation
…nces-under-05-algo 302 add detection of escrow balances under 0.5 algo
…d-asa-amount-for-maker-buy
…scrow-orders ✅Encapsulated restrict order logic and added algo escrow side
…/github.com/algodex/algodex-sdk into ✅301-acceptance-standardize-cut-order-logic
…d-asa-amount-for-maker-buy
…d-asa-amount-for-maker-buy
…scrow-asa-amount-less-than-user-inputted-asa-amount-for-maker-buy
…user-inputted-asa-amount-for-maker-buy 305 escrow asa amount less than user inputted asa amount for maker buy
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
0.5 algomeaning that a taker order will now either closeout an escrow order entirely or leave it open with at least a total of0.5 algo.execution:bothif a taker closes out all escrows at desired price and still hasn't achieved the initial desired amount, a maker order will only be placed if the total algo amount is greater than0.5 algo.type: buyso desired ASA amount ALWAYS matches what the user inputted. When adding to an orderbook a fee of0.001 algois taken directly from the algo total so by adding an extra0.001 algoto the total, the original asa amount is preserved. For selling ASA's the fees for adding to the orderbook are taken out of the0.5 algoprovided in the maker order.📝 Related Issues
#302
#303
#304
#305