Manny: FIXED challenge 3#68
Open
manny-uncharted wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
Open
Manny: FIXED challenge 3#68manny-uncharted wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
manny-uncharted wants to merge 1 commit intoalgorand-coding-challenges:mainfrom
Conversation
Contributor
|
🎉 Congrats on solving the 3rd Algorand Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Bug Submission Pull Request
What was the bug?
The bug existed in the code section where we created a new client that specifies how to identify and interact with the application using a deployer account. The issue was the creatorAddress didn't parse the deployer address, it only passed the deployer object and also we are to use algod instead of indexer
const appClient = new HelloWorldClient(
{
resolveBy: 'creatorAndName',
findExistingUsing: indexer,
sender: deployer,
creatorAddress: deployer,
},
indexer,
)
How did you fix the bug?
The first step was to:
deployer.addrAs the deployer is an object with an addr property that holds the creator's address.Console Screenshot:
