Skip to content

feat: puya debugging support; improved source map management #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 29, 2024

Conversation

aorumbayev
Copy link
Collaborator

Proposed Changes

  • Refined flow on managing sources.avm.json
  • Refined ui pickers (options to ignore sourcemap hash, or pick external file)
  • Extension commands to clear/edit sources avm json
  • Extension property to preset default sources.avm.json path
  • Backwards compatibility with previous version of extension

Further notes

  • Ignore CI issues, wip commits depend on a avm-debugger package, which is currently not available for install from forked repo (hence ref to a manually npm packed file that im using locally).
  • A few more tests cases to be added, but current stack runs correctly (with current local version of avm debugger that does not crash on null 'ignored' sourcemaps + Dan's spike changes)

@aorumbayev
Copy link
Collaborator Author

aorumbayev commented Sep 17, 2024

@daniel-makerx @neilcampbell , pushed latest tweak that filters out source maps to pass to DAP based on priority (only keep Puya if exists -> else Teal -> else Legacy teal prefixed with .tok). Other than that it still passes files however sourcemap registry file is now curated (only contains sourcemaps relevant for the executing trace -> after debug session is done it removes the file from users filesystem ).

Also fixed e2e tests in CI pipeline, latest VSCode version seems to act and run slower than previous iterations (probably due to the fact that wdio is relying on a wdio related vscode plugin which prevents us from being able to upgrade to latest stable wdio version).

@aorumbayev aorumbayev force-pushed the feat/puya-debugging branch from 5022812 to 4a395e9 Compare October 2, 2024 16:14
@aorumbayev
Copy link
Collaborator Author

@daniel-makerx added imports of the ProgramSourceEntryFile and ProgramSourceEntry from avm debugger instead of having the algokit extension replicate the interface

@aorumbayev aorumbayev force-pushed the feat/puya-debugging branch from 868eecf to f569703 Compare October 6, 2024 22:03
@aorumbayev aorumbayev force-pushed the feat/puya-debugging branch 2 times, most recently from ef4ccc6 to f446869 Compare October 6, 2024 22:52
@aorumbayev aorumbayev force-pushed the feat/puya-debugging branch from f446869 to fee21cf Compare October 6, 2024 23:16
@aorumbayev aorumbayev changed the title [DRAFT] feat: puya debugging support; improved source map management feat: puya debugging support; improved source map management Oct 7, 2024
@aorumbayev aorumbayev marked this pull request as ready for review October 14, 2024 19:12
Fixes the error thrown during npm package invocation:
 ERROR  @types/vscode ^1.92.0 greater than engines.vscode ^1.80.0. Either upgrade engines.vscode or use an older @types/vscode version
Co-authored-by: Neil Campbell <neil.campbell@makerx.com.au>
@aorumbayev aorumbayev merged commit 4a740db into main Oct 29, 2024
3 checks passed
@aorumbayev aorumbayev deleted the feat/puya-debugging branch October 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants