feat: app factory #248
Draft
feat: app factory #248
+6,849
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorumbayev
requested review from
lempira,
neilcampbell and
a team
and removed request for
a team
aorumbayev
force-pushed
the
feat/application-client
branch
from
6a166c7 to
6d27d07
Compare
aorumbayev
force-pushed
the
feat/app-factory
branch
from
30ec996 to
ae01c00
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an app factory pattern for Algorand application deployment in the Rust crate, following the established patterns from Python and TypeScript implementations. The factory provides a high-level interface for creating, updating, and deploying applications using ARC-56 specifications.
Key changes:
- New
AppFactorystruct with fluent API for application lifecycle management - Integration with existing
AppDeployerfor idempotent deployment operations - Enhanced
AlgorandClientwith persistent app deployer functionality
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/algokit_utils/src/applications/app_factory/ | Core factory implementation with modular design (types, compilation, transaction builders, etc.) |
| crates/algokit_utils/src/applications/app_client/types.rs | Changed AlgorandClient parameter to Arc for shared ownership |
| crates/algokit_utils/src/clients/algorand_client.rs | Added persistent AppDeployer instance and app_deployer() accessor method |
| crates/algokit_utils/src/applications/app_deployer.rs | Enhanced with extra program pages calculation and localnet retry logic |
| crates/algokit_utils/tests/applications/app_factory.rs | Comprehensive test suite covering factory creation, deployment, and ABI scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aorumbayev
force-pushed
the
feat/application-client
branch
from
1be959c to
fb7ee7f
Compare
aorumbayev
force-pushed
the
feat/app-factory
branch
from
ae01c00 to
d9de8df
Compare
Merged
… in app client; more tests
* wip - PR feedback * wip - convert errors to snafu * wip * chore: replace utils CommonTransactionParams with macro * chore(python/algokit_transact): bump version to 1.0.0-alpha.60 [skip ci] * wip - converting string to error types * chore: simplify add_app_method_call_internal * chore: additional tweaks whilst implementing TS composer * chore(python/algokit_transact): bump version to 1.0.0-alpha.61 [skip ci] * chore: adjust transaction creator types, as they were previously a bit strange * wip - fixing compile issues * fix types for transaction_builder * chore: tweaks to both transaction creator and client manager * wip - map storage * wip - app state * wip - some clean up * wip - fix compile issues * make app state accessor better * wip - box * box done * fix params_builder * chore(python/algokit_transact): bump version to 1.0.0-alpha.62 [skip ci] * fix up the app client * wip - fix simulate * fix simulate + send params * clean up compilation.rs * remove extract_abi_return_from_result * wip - fixing tests * wip - resolve compile error app_client tests * wip - fixing tests * chore: add default signer support to AppClientParams * wip - structs * fix field type + encode/decode logic * test * convert storage key to abi storage key * convert storage map to abi storage map * convert box to use abi storage key * fix build * wip- struct in default value * convert default value * fix up - it builds now * wip - fixing tests --------- Co-authored-by: engineering-ci[bot] <179917785+engineering-ci[bot]@users.noreply.github.com> Co-authored-by: Neil Campbell <neil.campbell@makerx.com.au> Co-authored-by: Altynbek Orumbayev <altynbek.orumbayev@makerx.com.au>
aorumbayev
force-pushed
the
feat/application-client
branch
from
afe47d6 to
092606d
Compare
…account for TransactionWithSigner Ensure transaction-typed ABI args inherit the method signer when not explicitly set
aorumbayev
force-pushed
the
feat/app-factory
branch
from
d9de8df to
03af463
Compare
aorumbayev
force-pushed
the
feat/app-factory
branch
from
03af463 to
fec24a9
Compare
aorumbayev
force-pushed
the
feat/application-client
branch
from
6ccfab0 to
17887bd
Compare
aorumbayev
force-pushed
the
feat/app-factory
branch
from
7d7e0f2 to
4c1741d
Compare
aorumbayev
force-pushed
the
feat/app-factory
branch
from
4c1741d to
94dc537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App factory implementation following the AppClient