Skip to content

fix: extract signature length constant and reuse across crate #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025

Conversation

CiottiGiorgio
Copy link
Member

Quick fix for extracting the signature length constant and reusing it in the core crate and the FFI crate.

Some files are changed because of cargo fmt but are otherwise unrelated to this change.

@CiottiGiorgio
Copy link
Member Author

Actually this is not ready yet. I'm trying to re-export the constants from the core crate out of the ffi crate (so that I can use it in utlis).

@CiottiGiorgio
Copy link
Member Author

I had to export the constants through functions but I don't think this is the best approach since it requires us to keep it updated with the underlying module.

# Conflicts:
#	crates/algokit_transact/src/constants.rs
#	crates/algokit_transact/src/tests.rs
#	crates/algokit_transact/src/transactions/mod.rs
#	crates/algokit_transact_ffi/src/lib.rs
* feat: consts as enum
@CiottiGiorgio
Copy link
Member Author

@neilcampbell the enum strategy was merged in here with a review for now. Lmk what do you think of it

@CiottiGiorgio CiottiGiorgio merged commit 532b786 into main May 21, 2025
19 checks passed
@CiottiGiorgio CiottiGiorgio deleted the chore/extract-signature-bytes-length branch May 21, 2025 08:20
@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants