-
Notifications
You must be signed in to change notification settings - Fork 5
fix: extract signature length constant and reuse across crate #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually this is not ready yet. I'm trying to re-export the constants from the core crate out of the ffi crate (so that I can use it in utlis). |
I had to export the constants through functions but I don't think this is the best approach since it requires us to keep it updated with the underlying module. |
# Conflicts: # crates/algokit_transact/src/constants.rs # crates/algokit_transact/src/tests.rs # crates/algokit_transact/src/transactions/mod.rs # crates/algokit_transact_ffi/src/lib.rs
* feat: consts as enum
@neilcampbell the enum strategy was merged in here with a review for now. Lmk what do you think of it |
🎉 This PR is included in version 1.0.0-alpha.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Quick fix for extracting the signature length constant and reusing it in the core crate and the FFI crate.
Some files are changed because of
cargo fmt
but are otherwise unrelated to this change.