Skip to content

Fix enum version to prevent it from using older versions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

besirkurtulmus
Copy link
Contributor

@besirkurtulmus besirkurtulmus commented May 21, 2020

As seen here: #17 users can have the following error when they use the client:

Traceback (most recent call last): ....... import re File "....py", line 142, in <module> class 

RegexFlag(enum.IntFlag): AttributeError: module 'enum' has no attribute 'IntFlag'

This happens when the user has a conflicting version on enum installed. enum.IntFlag was added in version 3.6 of enum.

This PR makes changes to the setup.py file to only install enum34 on versions older than Python3.4. I've also fixed the enum34 version to the latest version.

@besirkurtulmus besirkurtulmus requested a review from zeryx May 21, 2020 19:01
Copy link
Contributor

@kennydaniel kennydaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants