Conversation
Added support for additional interface orientations for iPad.
There was a problem hiding this comment.
Pull request overview
Updates the app’s supportedInterfaceOrientations configuration in the SwiftPM manifest to allow additional orientations on iPad while keeping iPhone portrait-only behavior.
Changes:
- Adds conditional iPad-only support for
landscapeRight,landscapeLeft, andportraitUpsideDowninsupportedInterfaceOrientations. - Keeps
.portraitenabled for all device families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| supportedInterfaceOrientations: [ | ||
| .portrait | ||
| .portrait, | ||
| .landscapeRight(.when(deviceFamilies: [.pad])), | ||
| .landscapeLeft(.when(deviceFamilies: [.pad])), | ||
| .portraitUpsideDown(.when(deviceFamilies: [.pad])) | ||
| ], |
There was a problem hiding this comment.
This change is made in an auto-generated manifest (see the warning at the top of this file). Any regeneration step (e.g., from Xcode/Swift Playgrounds) is likely to overwrite these orientation updates. Please apply this change in the source that generates Beacon.swiftpm/Package.swift (or document/update the generation workflow) so it persists.
| supportedInterfaceOrientations: [ | ||
| .portrait | ||
| .portrait, | ||
| .landscapeRight(.when(deviceFamilies: [.pad])), | ||
| .landscapeLeft(.when(deviceFamilies: [.pad])), | ||
| .portraitUpsideDown(.when(deviceFamilies: [.pad])) |
There was a problem hiding this comment.
The PR title/description mention adding a requiresFullScreen property, but this diff only updates supportedInterfaceOrientations. Either add the requiresFullScreen change (if intended) or update the PR metadata so it accurately reflects the actual change set.
| .portrait, | ||
| .landscapeRight(.when(deviceFamilies: [.pad])), | ||
| .landscapeLeft(.when(deviceFamilies: [.pad])), | ||
| .portraitUpsideDown(.when(deviceFamilies: [.pad])) |
There was a problem hiding this comment.
Indentation of the items in supportedInterfaceOrientations appears inconsistent with nearby arrays in this file. Please reformat this block to keep the manifest readable and consistent.
| .portrait, | |
| .landscapeRight(.when(deviceFamilies: [.pad])), | |
| .landscapeLeft(.when(deviceFamilies: [.pad])), | |
| .portraitUpsideDown(.when(deviceFamilies: [.pad])) | |
| .portrait, | |
| .landscapeRight(.when(deviceFamilies: [.pad])), | |
| .landscapeLeft(.when(deviceFamilies: [.pad])), | |
| .portraitUpsideDown(.when(deviceFamilies: [.pad])) |
This pull request updates the supported interface orientations for the app in
Package.swiftto improve the user experience on iPad devices.User interface improvements:
landscapeRight,landscapeLeft, andportraitUpsideDownorientations specifically for iPads, while keeping onlyportraitfor other devices in thesupportedInterfaceOrientationsarray inPackage.swift.