Skip to content

Re-ordered code to allow easy inclusion of floodyberrys repo#1

Open
Thirtybird wants to merge 26 commits intoali1234:masterfrom
Thirtybird:master
Open

Re-ordered code to allow easy inclusion of floodyberrys repo#1
Thirtybird wants to merge 26 commits intoali1234:masterfrom
Thirtybird:master

Conversation

@Thirtybird
Copy link
Copy Markdown

included removing scrypt-jane.c and scrypt-jane.h from the main directory and putting the GetNFactor and scanhash_scrypt_jane functions directly into cpu-miner.c.
Included latest version of scrypt-jane library which fixes problems with compiling under mingw

moved yacoin specific routines into yacoin.c

@ali1234
Copy link
Copy Markdown
Owner

ali1234 commented Jun 5, 2013

scanhash_scrypt is not in cpu-miner.c so why would you put scanhash_scrypt_jane in it?

@Thirtybird
Copy link
Copy Markdown
Author

Sorry for the terse reply earlier - was trying to get my ducks in a row
while in a meeting.

One of the concerns, and reasons I wanted to separate things out was
because of the perception of YAC=scrypt-jane. Scrypt-Jane just being the
library, I wanted to move the code that is specific to YACoin out of any
files that were specific to the scrypt-jane library. I had initially put
the GetNFactor and scanhash_scrypt_jane into YACoin.c/h and renamed them
appropriately to designate that they're specific to YACoin (being possible
to use scrypt-jane for other hashing things other than keccak with chacha).
As it's your repo, what are your thoughts - how would you organize it?

On Wed, Jun 5, 2013 at 2:27 PM, Alistair Buxton notifications@github.comwrote:

scanhash_scrypt is not in cpu-miner.c so why would you put
scanhash_scrypt_jane in it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-18997152
.

@Thirtybird
Copy link
Copy Markdown
Author

The changes specific to compiling for YACoin have been moved out into their own files, and I've verified it compiles under MinGW32. Forcing the compiler option for the architecture, the hashrate for my CPU architecture give me the same hashrates as the 32-bit version compiled and posted by god3 at https://bitcointalk.org/index.php?topic=201027.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants